Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Modules to support CVP 2020 releases #129

Closed
Hugh-Adams opened this issue Jan 28, 2020 · 1 comment
Closed

Update Modules to support CVP 2020 releases #129

Hugh-Adams opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
state: accepted Issue is part of the development roadmap status: testing PR under testing type: enhancement New feature or request
Milestone

Comments

@Hugh-Adams
Copy link
Contributor

Issue Type

  • Feature Idea

Module Name

cv_client.py and 'cv_api2020.py' Python libraries


OS / Environment

Summary

Steps to reproduce

Expected results

cv modules correctly identify new version of CVP

Actual results

Does not support CVP 2020.1.0 - cv_client.py does not identify the CVP version correctly.
Requires the following lines adding to _set_api_version: line 219

         elif int(self.splitVersion[0]) == 2020:
             self.log.info('Setting API version to 2020')
             self.apiVersion = '2020'
             self.apiName = 'cv_api2020'
             if init:
                 from ansible_collections.arista.cvp.plugins.module_utils.cv_api2020 import CvpApi

and also the creation of cv_api2020.py based on cv_api2019.py


@Hugh-Adams Hugh-Adams added the status: Triage New incoming issue label Jan 28, 2020
@titom73 titom73 added the type: enhancement New feature or request label Jan 29, 2020
@titom73 titom73 added state: accepted Issue is part of the development roadmap and removed status: Triage New incoming issue labels Mar 3, 2020
@titom73 titom73 assigned titom73 and Hugh-Adams and unassigned titom73 Mar 3, 2020
@Hugh-Adams
Copy link
Contributor Author

Hugh-Adams commented Mar 3, 2020 via email

@titom73 titom73 added this to the v1.1 milestone Mar 7, 2020
@Hugh-Adams Hugh-Adams linked a pull request Mar 17, 2020 that will close this issue
@Hugh-Adams Hugh-Adams removed a link to a pull request Mar 17, 2020
@Hugh-Adams Hugh-Adams linked a pull request Mar 17, 2020 that will close this issue
@titom73 titom73 added the status: in-progress Currently under investigation or implementation label Mar 20, 2020
@titom73 titom73 mentioned this issue Apr 3, 2020
4 tasks
titom73 added a commit that referenced this issue Apr 7, 2020
@titom73 titom73 added status: testing PR under testing and removed status: in-progress Currently under investigation or implementation labels Apr 7, 2020
@titom73 titom73 closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: accepted Issue is part of the development roadmap status: testing PR under testing type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants