Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #161 - add parsing of secondary ip from interfaces #251

Merged
merged 2 commits into from
Feb 19, 2023
Merged

fix issue #161 - add parsing of secondary ip from interfaces #251

merged 2 commits into from
Feb 19, 2023

Conversation

dlyssenko
Copy link
Contributor

@dlyssenko dlyssenko commented Feb 13, 2023 •
edited
Loading

implemented requests #161, added the respective unittest.

@dlyssenko dlyssenko requested a review from mharista February 13, 2023 15:34
mharista
mharista reviewed Feb 18, 2023
View reviewed changes
Copy link
Contributor

@mharista mharista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions. Otherwise looks good.

Makefile Show resolved Hide resolved
@dlyssenko dlyssenko merged commit 7a2d236 into arista-eosplus:develop Feb 19, 2023
@dlyssenko dlyssenko deleted the fix_ench_161_add_parsing_secondary_ip branch February 19, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharista mharista mharista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlyssenko @mharista