-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10 support (and migrate to GitHub actions) #223
Conversation
No longer needed, and incomplete.
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: ['3.5', '3.6', '3.7', '3.8', '3.9', '3.10'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything below Python 3.7 is EOL. I suggest to stick to supported Python releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that'd be sensible. I don't know what the maintainers want to be supporting, though?
@dlyssenko this seems pretty straight forward? Would be good to get 3.10 support. |
@stefanor, @shimamizu, @fabaff. W.r.t. switching over to Github workflow (ebdbb24) - I'm myself in favor of this decision, probably will approve after checking with my team. For the supported versions in CI (cc9c584) - I'd think we still need even 2.7 - some of our customers might still use it, documentations is still being built using sphinx on python2, EOS integration still relies on python2 and system tests are not yet entirely migrated over to python3. We're making an effort to migrate completely to python3, but it takes time, until then we'd need to include 2.7 into the CI workflow. for the same reason I cannot approve 81754f5 - but PR #235, #239 ensure compatibility, so that one could be dropped entirely. |
closing this PR with that. |
Iterable
moved tocollections.abc
in3.3
Fixes: #195
While we're here, migrate to GitHub actions, so we can have CI, again.