Clean up spec tests and pull in JJM 14149 #17 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed merged into develop branch
- consolidate fixtures in to 1 file to avoid collisions and convert to YAML format.
- Consolidated several test fixtures - Removed check in tacacs for unsupported 'enable' property
| @@ -40,11 +47,11 @@ def source_interface=(val) | |||
|
|
|||
| def create | |||
| node.api('logging').add_host(resource[:name]) | |||
| @provider_hash = { name: resource[:name], ensure: :present } | |||
| @property_hash = { name: resource[:name], ensure: :present } | |||
There was a problem hiding this comment.
Why didn't the use of the wrong name break the unit test for the provider?
There was a problem hiding this comment.
changing "provider_hash" to "property_hash" fixes the following failure:
1) Puppet::Type::Syslog_server::ProviderEos resource (instance) methods #create sets ensure to :present
Failure/Error: expect(provider.ensure).to eq(:present)
expected: :present
got: :absent
(compared using ==)
Diff:
@@ -1,2 +1,2 @@
-:present
+:absent
# ./spec/unit/puppet/provider/syslog_server/eos_spec.rb:141:in `block (4 levels) in <top (required)>'
privateip
added a commit
that referenced
this pull request
Jun 5, 2015
Clean up spec tests and pull in JJM 14149 #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16