Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlasaction: gitlab ci #242

Merged
merged 20 commits into from
Oct 13, 2024
Merged

atlasaction: gitlab ci #242

merged 20 commits into from
Oct 13, 2024

Conversation

noamcattan
Copy link
Member

No description provided.

Copy link

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

github-actions bot commented Sep 25, 2024

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Result
1 new migration file detected 20230925192914.sql
ERD and visual diff generated View Visualization
Analyze 20230925192914.sql
1 reports were found in analysis
Destructive changes detected
Dropping table "t1" (DS102)
Read the full linting report on Atlas Cloud

Copy link

github-actions bot commented Sep 25, 2024

Atlas detected changes to the desired schema

SQL Plan

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL
);
-- Create "t4" table
CREATE TABLE `t4` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes4 new statements detected
No issues found

📝 To edit this plan, follow these steps
  1. Run atlas schema plan pull --url "atlas://atlas-action/plans/pr-242-R1cGcSfo" > pr-242-R1cGcSfo.plan.hcl
  2. Modify the plan.
  3. Push the plan using atlas schema plan push --pending --env test --file pr-242-R1cGcSfo.plan.hcl
  4. Re-trigger this action using gh run rerun 11036404310

Copy link

github-actions bot commented Oct 6, 2024

Atlas detected changes to the desired schema

Migration Plan (View on Atlas Cloud)

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL
);
-- Create "t4" table
CREATE TABLE `t4` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes4 new statements detected
No issues found

📝 To edit this plan, follow these steps
  1. Run atlas schema plan pull --url "atlas://atlas-action/plans/pr-244-R1cGcSfo" > pr-244-R1cGcSfo.plan.hcl
  2. Modify the plan.
  3. Push the plan using atlas schema plan push --pending --env test --file pr-244-R1cGcSfo.plan.hcl
  4. Re-trigger this action using gh run rerun 11202776932

atlasaction/action.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 10, 2024

Atlas detected changes to the desired schema

Migration Plan (View on Atlas Cloud)

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes3 new statements detected
No issues found

📝 To edit this plan, follow these steps
  1. Run atlas schema plan pull --url "atlas://atlas-action/plans/pr-196-ufnTS7Nr" > pr-196-ufnTS7Nr.plan.hcl
  2. Modify the plan.
  3. Push the plan using atlas schema plan push --pending --env test --file pr-196-ufnTS7Nr.plan.hcl
  4. Re-trigger this action using gh run rerun 11312593803

@noamcattan noamcattan marked this pull request as ready for review October 10, 2024 08:37
Copy link
Member

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look goods, please add testscript to ensure input/output are correct.

Copy link
Member

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All goods, one mirror comment

@noamcattan noamcattan merged commit 77034d8 into master Oct 13, 2024
19 checks passed
@noamcattan noamcattan deleted the gitlab-ci branch October 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants