-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 192 #194
Issue 192 #194
Conversation
Fix build on windows devices by manually setting undefined for a not defined prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this turned out to be a bit more than anticipated! cool news is I think this is really going to up the bar for animation libraries and reduced motion, thanks so much for kicking this off.
there's comments all over the place, mostly me realizing stuff and offering some code suggestions. 11 comments sounds like a lot lol, but i think it'll go quick! 🙏🏻
here's all of them turned on, aka showing them in their worst light but also an overview
Kapture.2022-02-22.at.22.17.39.mp4
Done. Somone needs to check the reduced motion timings. Especially shake & bounce are behaving a bit weird. |
did some polish and fixed an animation, made a PR to your branch! https://github.com/Que-tin/open-props/pull/1 |
adds fixes/docs for combo examples, fixes scale animations
@argyleink Checked and tested everything, looks good to me 👍🏻😊 Your PR also got merged. |
Next step is I'll host the feature and send it to a few folks I trust and who prefer reduced motion, have them test it and give it some QA 👍🏻 |
review #1:
|
i still think about these efforts and where they should go 🙂 |
Closed due to the progress pn #341 |
No description provided.