Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: neptune v12.1.0 #250

Closed
wants to merge 1 commit into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2023

This is a release PR for version 12.1.0.

You will still need to manually publish the cargo crate:

$ make VERSION=12.1.0 release

@huitseeker
Copy link
Contributor

`cargo public-api diff latest` output
Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
+impl core::clone::Clone for neptune::poseidon::HashMode
+pub fn neptune::poseidon::HashMode::clone(&self) -> neptune::poseidon::HashMode
+impl core::marker::Copy for neptune::poseidon::HashMode
+impl<T> alloc::borrow::ToOwned for neptune::poseidon::HashMode where T: core::clone::Clone
+pub type neptune::poseidon::HashMode::Owned = T
+pub fn neptune::poseidon::HashMode::clone_into(&self, target: &mut T)
+pub fn neptune::poseidon::HashMode::to_owned(&self) -> T
+pub fn neptune::poseidon::PoseidonConstants<F, A>::new_from_parameters(width: usize, m: alloc::vec::Vec<alloc::vec::Vec<F>>, round_constants: alloc::vec::Vec<F>, full_rounds: usize, partial_rounds: usize, hash_type: neptune::hash_type::HashType<F, A>, strength: neptune::Strength) -> Self

@huitseeker huitseeker force-pushed the release/neptune/12.1.0 branch from 7f1ad43 to f68b52d Compare November 8, 2023 16:18
@huitseeker huitseeker requested a review from porcuquine November 8, 2023 16:20
Copy link
Contributor

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily blocking until receiving explicit confirmation this isn't a minor release with a major bump of common downstream dependencies.

@huitseeker huitseeker marked this pull request as draft November 8, 2023 17:40
@huitseeker
Copy link
Contributor

huitseeker commented Nov 8, 2023

OK, so for my own memory:

The original sin is we (unnecessarily) bumped the `bellpepper-core` version to 0.3.0, which is a leftmost bump marking incompatibility.
[email protected]➜~/tmp/bellpepper(main)» cargo public-api -p bellpepper-core diff v0.3.0..v0.4.0
 Documenting bellpepper-core v0.3.0 (/Users/huitseeker/tmp/bellpepper/crates/bellpepper-core)
    Finished dev [unoptimized + debuginfo] target(s) in 0.26s
 Documenting bellpepper-core v0.4.0 (/Users/huitseeker/tmp/bellpepper/crates/bellpepper-core)
    Finished dev [unoptimized + debuginfo] target(s) in 0.26s
Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
(none)

[email protected]➜~/tmp/bellpepper(main)» cargo public-api -p bellpepper diff v0.3.0..v0.4.0
 Documenting bellpepper v0.3.0 (/Users/huitseeker/tmp/bellpepper/crates/bellpepper)
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
 Documenting bellpepper v0.4.0 (/Users/huitseeker/tmp/bellpepper/crates/bellpepper)
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
+impl<Scalar> bellpepper::util_cs::witness_cs::WitnessCS<Scalar> where Scalar: ff::PrimeField
+pub fn bellpepper::util_cs::witness_cs::WitnessCS<Scalar>::aux_assignment(&self) -> &[Scalar]
+pub fn bellpepper::util_cs::witness_cs::WitnessCS<Scalar>::input_assignment(&self) -> &[Scalar]
And anyone that depends on bellpepper-core through crate versions which are *not* inherited from `neptune` will import two versions of this crate, which implementations will resolve to be incompatible.

So this needs to be a major version bump. 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants