-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Halo2: Updates from latest master #168
Conversation
I think https://github.com/filecoin-project/neptune/tree/halo2-gpu is already doing most of this. |
36c7359
to
9ac186e
Compare
Yeah, thanks for pointing. We can pick changes from your branch into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if we just force-push the halo2-gpu
branch as halo2
as it has a linear history.
@vmx , I don't mind using |
@storojs72 I've force-pushed |
@vmx , thank you. I'm picking edited |
filecoin-project/rust-fil-proofs#1656 is working with updated |
This PR updates halo2 branch of
neptune
to 0.8.1 as it is in master currently and fixes halo2 <-> master "behind" divergence.It is required for updating halo2 branch of
rust-fil-proofs
eventually.@vmx, @DrPeterVanNostrand, I guess, You are aware of
master
commits, so I would ask to review 9ac186e more carefully than others, as it contains merge conflicts fixes.