Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
Also addresses the nit from https://github.com/argumentcomputer/loam/pull/260#discussion_r1735229332
This PR does not try to generate a
CryptoProof
from theMachineProof
since the former is in a private module, and exposing it might expose too much aspub
we might not want to expose yet. It's extra annoying sincetests/fib.rs
is technically a separate crate so it couldn't just bepub(crate)
.I've manually tested the conversion in the REPL, and indeed when there are multiple shards, all the shards have the same public values and the
CryptoProof
conversion works fine.