Moving TestShapeCS
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2024
adr1anh
reviewed
Mar 21, 2024
Comment on lines
+71
to
+94
| fn proc_lc<Scalar: PrimeField>( | ||
| terms: &LinearCombination<Scalar>, | ||
| ) -> BTreeMap<OrderedVariable, Scalar> { | ||
| let mut map = BTreeMap::new(); | ||
| for (var, &coeff) in terms.iter() { | ||
| map.entry(OrderedVariable(var)) | ||
| .or_insert_with(|| Scalar::ZERO) | ||
| .add_assign(&coeff); | ||
| } | ||
|
|
||
| // Remove terms that have a zero coefficient to normalize | ||
| let mut to_remove = vec![]; | ||
| for (var, coeff) in map.iter() { | ||
| if coeff.is_zero().into() { | ||
| to_remove.push(*var) | ||
| } | ||
| } | ||
|
|
||
| for var in to_remove { | ||
| map.remove(&var); | ||
| } | ||
|
|
||
| map | ||
| } |
There was a problem hiding this comment.
The method is private. As we are trying to only merge changes to bellpepper in dev and changes to bellpepper-core in main I propose that I add a todo for DRY in the code and open an issue that can be tackled on the next bellpepper-core release.
Does that sound alright?
adr1anh
approved these changes
Mar 21, 2024
wwared
pushed a commit
that referenced
this pull request
Aug 7, 2024
samuelburnham
pushed a commit
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR moves the
TestShapeCSfromarecibofrombellpepper. It changes the generic type fromEnginetoPrimeFieldto do so. This does not imply big changes as we were only leveragingE::Scalaranyway.Parallel to this PR I have created a branch on
arecibo, which we can use to integrate these changes once they are merged. The branch removes theTestShapeCSwhile also revamping theShapeCSto only usePrimeFieldand notEngine. This was done for uniformity but can be reverted if we deem the change to introduce too many mandatory types indication (eg: 1, 2, ...)