Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing errors. #72

Merged
merged 10 commits into from
Aug 26, 2022
Merged

Fix typing errors. #72

merged 10 commits into from
Aug 26, 2022

Conversation

benjaminrwilson
Copy link
Collaborator

@benjaminrwilson benjaminrwilson commented Jun 3, 2022

PR Summary

Testing

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

@benjaminrwilson benjaminrwilson changed the title Unpin numpy. Fix typing errors. Jun 6, 2022
@benjaminrwilson benjaminrwilson marked this pull request as ready for review August 13, 2022 01:49
@benjaminrwilson
Copy link
Collaborator Author

@wqi , do you mind taking another look? I had to make some additional changes to satisfy mypy.

@benjaminrwilson benjaminrwilson merged commit 31d7e2a into main Aug 26, 2022
@benjaminrwilson benjaminrwilson deleted the unpin-numpy branch August 26, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants