Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_city_name() method to dataloader, to fetch name of city where a log was captured. #27

Merged
merged 9 commits into from
Apr 1, 2022
Merged
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/av2/datasets/sensor/av2_sensor_dataloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ def __init__(self, data_dir: Path, labels_dir: Path) -> None:
self._labels_dir = labels_dir
self._sdb = SynchronizationDB(str(data_dir))

def get_city_name(self, log_id: str) -> str:
"""Return the name of the city where the log of interest was captured."""
raise NotImplementedError("Method is not available yet.")

def get_log_pinhole_camera(self, log_id: str, cam_name: str) -> PinholeCamera:
"""Return a PinholeCamera parameterized by sensor pose in vehicle frame, intrinsics, and image dimensions."""
log_dir = self._data_dir / log_id
Expand Down Expand Up @@ -136,6 +132,28 @@ def get_log_map_dirpath(self, log_id: str) -> Path:
"""Fetch the path to the directory containing map files for a single vehicle log."""
return self._data_dir / log_id / "map"

def get_city_name(self, log_id: str) -> str:
"""Return the name of the city where the log of interest was captured.

Vector map filenames contain the city name, and have a name in the following format:
`log_map_archive_453e5558-6363-38e3-bf9b-42b5ba0a6f1d____PAO_city_71741.json`

Args:
log_id: unique ID of vehicle log.

Returns:
Name of the city where the log of interest was captured.

Raises:
RuntimeError: If no vector map file is found for the query log ID.
"""
vector_map_fpaths = list(self._data_dir.glob(f"{log_id}/map/log_map_archive*"))
if len(vector_map_fpaths) != 1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a check for if there's an extra vector map file in the directory?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminrwilson thanks for the review. I think this logic is checking for that case already, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for sure --- the string for the RuntimeError would be a little misleading in that case though, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I changed the check to == 0 now, which I think is the more intuitive case (the log is not present).

raise RuntimeError(f"Vector map file is missing for {log_id}")
benjaminrwilson marked this conversation as resolved.
Show resolved Hide resolved
vector_map_fpath = vector_map_fpaths[0]
log_city_name = vector_map_fpath.name.split("____")[1].split("_")[0]
return log_city_name

def get_log_ids(self) -> List[str]:
"""Return a list of all vehicle log IDs available at the provided dataroot."""
return sorted([d.name for d in self._data_dir.glob("*") if d.is_dir()])
Expand Down