Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license attribute in package.json? #590

Closed
bacall213 opened this issue Sep 6, 2024 · 1 comment · Fixed by #591
Closed

Missing license attribute in package.json? #590

bacall213 opened this issue Sep 6, 2024 · 1 comment · Fixed by #591

Comments

@bacall213
Copy link

💬 Questions and Help

Is there any particular reason the license attribute is not included in package.json?

The jest-puppeteer github repo doesn't seem to include it in any of the versions I've checked back to v3, but the npmjs mirror of jest-puppeteer v6.2.0 appears to have included the license attribute.

When viewing the package on npmjs, license detection is failing to detect the MIT license in the license file so it's tagging the packages as having no license even though there is clearly a license.

To view this another way, if you run: npm view [email protected] you'll get something like this: [email protected] | MIT | deps: 2 | versions: 61

Checking the next version: npm view [email protected] returns [email protected] | Proprietary | deps: 2 | versions: 61

All subsequent versions I've checked return the same Proprietary license tag even though the LICENSE file hasn't changed.

gregberge added a commit that referenced this issue Sep 6, 2024
gregberge added a commit that referenced this issue Sep 6, 2024
@gregberge
Copy link
Member

Fixed in latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants