fix: sync hooks should be deleted after sync phase/wave completion #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannfis
approved these changes
Jul 15, 2020
pkg/sync/sync_context.go
Outdated
| return task.isHook() && task.liveObj != nil && !task.running() && task.deleteOnPhaseCompletion() | ||
| }) | ||
| for _, task := range hooksPendingDeletion { | ||
| if task.deleteOnPhaseCompletion() { |
There was a problem hiding this comment.
Is this check necessary? It's already part of the task filter above.
There was a problem hiding this comment.
nice catch, thank you! the check is not required - removed.
| return nil, nil | ||
| } | ||
|
|
||
| func TestRunSync_HooksNotDeletedIfPhaseNotCompleted(t *testing.T) { |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 53.52% 55.01% +1.48%
==========================================
Files 25 25
Lines 2638 2643 +5
==========================================
+ Hits 1412 1454 +42
+ Misses 1086 1048 -38
- Partials 140 141 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes argoproj/argo-cd#2737
PR changes hook deletion logic so that hooks are deleted after sync phase/wave is completed.