fix: Hook Deletion Policies HookSucceeded should be run after whole H… #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook succeed and not only Resource succeed
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 53.86% 54.29% +0.42%
==========================================
Files 25 25
Lines 2404 2422 +18
==========================================
+ Hits 1295 1315 +20
+ Misses 974 972 -2
Partials 135 135
Continue to review full report at Codecov.
|
alexmt
requested changes
Sep 29, 2020
There was a problem hiding this comment.
Tried to test it and found a bug. Following pre-sync hook has HookFailed delete policy, always fails but never got deleted.
apiVersion: batch/v1
kind: Job
metadata:
name: before
annotations:
argocd.argoproj.io/hook: PreSync
argocd.argoproj.io/hook-delete-policy: HookFailed
spec:
template:
spec:
containers:
- name: sleep
image: alpine:latest
command: ["fail"]
restartPolicy: Never
backoffLimit: 0
|
Kudos, SonarCloud Quality Gate passed!
|
|
fixes argoproj/argo-cd#4384 |
mayzhang2000
added a commit
that referenced
this pull request
Oct 29, 2020
#144) * fix: Hook Deletion Policies HookSucceeded should be run after whole Hook succeed and not only Resource succeed * fix: handle HookFailed. * fix: fixing lint error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ook succeed and not only Resource succeed