fix: submodule cloning via git. Fixes #7469 #8225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hunter-Thompson
changed the title
alexec
reviewed
Mar 23, 2022
|
I've created fork here: https://github.com/argoproj-labs/go-git Can you create a PR for your changes pls? |
created it |
I can also update this PR to use the argo fork. |
Signed-off-by: Hunter-Thompson <[email protected]>
done |
alexec
reviewed
Mar 24, 2022
Signed-off-by: Hunter-Thompson <[email protected]>
|
Not sure why the tests are failing. |
Signed-off-by: Hunter-Thompson <[email protected]>
alexec
approved these changes
Mar 24, 2022
sarabala1979
pushed a commit
that referenced
this pull request
Apr 18, 2022
* fix: submodule cloning via git. Fixes #7469 Signed-off-by: Hunter-Thompson <[email protected]> * chore: add smallcase to USERS.md Signed-off-by: Hunter-Thompson <[email protected]> * chore: move into require block Signed-off-by: Hunter-Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hunter-Thompson [email protected]
Fixes #7469
The original PR on go-git (go-git/go-git#464) has not been merged since more than a month, with no reply from the maintainers. I think this bug is very big, being unable to clone sub modules makes workflows impossible.
I suggest using a fork that we(smallcase) maintain until that PR is merged.
smallcase/go-git#2