test: Fixes various tests #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Joibel
added a commit
to Joibel/argo-workflows
that referenced
this pull request
Jul 23, 2024
testify/suite breaks parallel cron testing which was introduced in argoproj#2118 The breakage probably happened in argoproj#2874 testify know this stretchr/testify#187 and will not be fixing it. The fix here is inspired by @Jerska in stretchr/testify#187 (comment) It has a potential race but we won't be affected by it as all the tests take time to run. The tests are designed around running starting on a minute boundary for reliabilty, and as we add more tests without this fix it * increases overall reliability * test-to-test runtime varies, changing the start time relative to a minute boundary of a test, increasing uncertainty in how many instances of a cron will run. Tested locally by running the suite Signed-off-by: Alan Clucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2623
Fixes: #2833
Fixes: #2620