Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't add configmap volumemounts in wait container. Partial fix for #13089 #13741

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tooptoop4
Copy link
Contributor

Fixes point 2 of #13089

@agilgur5 agilgur5 changed the title feat: don't add configmap volumemounts in wait container(#13089) feat: don't add configmap volumemounts in wait container. Partial fix for #13089 Oct 12, 2024
@jswxstw
Copy link
Member

jswxstw commented Oct 16, 2024

Do you mean the ConfigMap named argo-env-config?

volumeConfig := apiv1.Volume{
Name: "argo-env-config",
VolumeSource: apiv1.VolumeSource{
ConfigMap: &apiv1.ConfigMapVolumeSource{
LocalObjectReference: apiv1.LocalObjectReference{
Name: cmName,
},
},
},
}

@tooptoop4
Copy link
Contributor Author

Do you mean the ConfigMap named argo-env-config?

volumeConfig := apiv1.Volume{
Name: "argo-env-config",
VolumeSource: apiv1.VolumeSource{
ConfigMap: &apiv1.ConfigMapVolumeSource{
LocalObjectReference: apiv1.LocalObjectReference{
Name: cmName,
},
},
},
}

@jswxstw i mean to exclude user configmaps like somecode.py they choose to mount, of which there could be several different ones mounted

@jswxstw
Copy link
Member

jswxstw commented Oct 17, 2024

@jswxstw i mean to exclude user configmaps like somecode.py they choose to mount, of which there could be several different ones mounted

You should write the PR description more clearly, otherwise we won't know why and how you actually do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants