Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ARGO_TEMPLATE env var without inputs #13064

Closed
wants to merge 10 commits into from

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented May 18, 2024

Fixes #8790

Motivation

reduce etcd growth

Modifications

will likely need env variable and else block to maintain existing functionality for some users

@tooptoop4 tooptoop4 closed this May 31, 2024
@tooptoop4 tooptoop4 reopened this May 31, 2024
@tooptoop4 tooptoop4 closed this Jun 1, 2024
@tooptoop4 tooptoop4 reopened this Jun 1, 2024
@tooptoop4
Copy link
Contributor Author

what do u think @jswxstw ?

@jswxstw
Copy link
Member

jswxstw commented Sep 30, 2024

I think this is a better way to decrease the size of pod envs: #8790 (comment).

@tooptoop4
Copy link
Contributor Author

superseded by #13742

@tooptoop4 tooptoop4 closed this Oct 11, 2024
@agilgur5 agilgur5 changed the title feat: argo_template env variable without inputs feat: ARGO_TEMPLATE env var without inputs Oct 12, 2024
@agilgur5 agilgur5 added area/controller Controller issues, panics area/executor solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) labels Oct 12, 2024
@agilgur5
Copy link
Contributor

You can force push over your old commits to fix DCO instead of opening a new PR (which creates a bit of pollution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/executor solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicative env var ARGO_TEMPLATE result in etcd size 1MB limit
3 participants