chore(deps): upgrade prettier from v1.x to v3+
#12290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and correspondingly update `eslint-config-prettier` from v3.x to v5+
- reformat UI codebase according to `prettier` v3 rules
- added two new "preferences" to dramatically shrink the diff (by an order of magnitude or two)
- `"trailingComma": "none"` and `"arrowParens": "avoid"` preserve the existing style of the codebase
- to be explicit, these are **not** _my_ preferences, just that which was already in the codebase
- we may certainly want to change these later, but at this time I chose to reduce the number of changes
Signed-off-by: Anton Gilgur <[email protected]>
- alphabetize `.prettierrc` - only the last two preferences had to be moved - a few promise chains were reformatted to long one-liners - instead change these to use newer async/await syntax Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
added
type/dependencies
terrytangyuan
approved these changes
Nov 30, 2023
This was referenced Jan 14, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12163, which unblocked the
prettierupgradePartial fix for #11740 as well
Motivation
Update to the latest version of
prettier. 1.x has not received an update in 4 years.Also unblock using newer TS syntax such as
import typeandexport typefrom TS 3.8 that Prettier v2+ added support forApiDocsandReportscomponents #12061 (export typethere), refactor(ui): code-split out largextermdep #12158, etcModifications
update
prettierfrom v1.x to v3+ and correspondingly updateeslint-config-prettierfrom v3.x to v5+reformat UI codebase according to
prettierv3 rules"trailingComma": "none"and"arrowParens": "avoid"preserve the existing style of the codebaseadditional related manual formatting
alphabetize
.prettierrca few promise chains were reformatted to long one-liners
Verification
make lint/yarn lintpass