fix: fix bugs in throttler and syncManager initialization in WorkflowController #11210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smile-luobin <[email protected]>
smile-luobin
changed the title
Signed-off-by: smile-luobin <[email protected]>
smile-luobin
changed the title
terrytangyuan
approved these changes
Jun 26, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…Controller (argoproj#11210) Signed-off-by: smile-luobin <[email protected]>
61 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Jul 19, 2023
…Controller (#11210) Signed-off-by: smile-luobin <[email protected]>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…Controller (argoproj#11210) Signed-off-by: smile-luobin <[email protected]> Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9875
fixes bugs in throttler and syncManager initialization in WorkflowController.
Motivation
Previously, we just list all running workflows in the
wc.namespaceto initialize throttler and syncManager.argo-workflows/workflow/controller/controller.go
Line 368 in b07de99
As we can install argo-workflows as
cluster-install, we may create workflows in any namespaces, instead of just in thewc.namespace.this initialize function may broken the throttler and syncManager if there are workflows running in other namespaces.