fix: DB sessions are recreated whenever controller configmap updates. Fixes #10498 #10734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes argoproj#10498 Signed-off-by: Yuan Tang <[email protected]>
terrytangyuan
commented
Mar 22, 2023
| @@ -152,3 +142,13 @@ func CreateMySQLDBSession(kubectlConfig kubernetes.Interface, namespace string, | |||
| } | |||
| return session, cfg.TableName, nil | |||
| } | |||
|
|
|||
| // ConfigureDBSession configures the DB session | |||
| func ConfigureDBSession(session sqlbuilder.Database, persistPool *config.ConnectionPool) sqlbuilder.Database { | |||
There was a problem hiding this comment.
This is a separate function because once we reused a session, we still want to update the configurations based on configmap changes in updateConfig().
Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
33 tasks
alexec
approved these changes
Mar 24, 2023
terrytangyuan
added a commit
that referenced
this pull request
Mar 29, 2023
3 tasks
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10498. The issue is that after change b0f0c58 introduced in 3.4.5, new DB sessions are re-created every time when the configmap changes. This PR allows reusing the DB session.