Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show message in kubectl get wf and argo list #8307

Closed
alexec opened this issue Apr 3, 2022 · 1 comment · Fixed by #8353
Closed

Show message in kubectl get wf and argo list #8307

alexec opened this issue Apr 3, 2022 · 1 comment · Fixed by #8353
Assignees
@sourikghosh
Labels
area/cli The `argo` CLI good first issue Good for newcomers type/feature Feature request

Comments

@alexec
Copy link
Contributor

alexec commented Apr 3, 2022

We don't surface the message for either. We should as it would be very helpful for understanding why a workflow failed.

argo-workflows/util/printer/workflow-printer.go

Line 57 in 9c90145

func printTable(wfList []wfv1.Workflow, out io.Writer, opts PrintOpts) {

argo-workflows/pkg/apis/workflow/v1alpha1/workflow_types.go

Line 122 in 9c90145

// +kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.phase",description="Status of the workflow"

This feature will have massive big bang for the buck.
@alexec alexec added type/feature Feature request good first issue Good for newcomers area/cli The `argo` CLI labels Apr 3, 2022
@sourikghosh
Copy link

@alexec Can I pick this ??
/assign

@rohankmr414 rohankmr414 mentioned this issue Apr 9, 2022
Merged
alexec pushed a commit that referenced this issue Apr 10, 2022
@rohankmr414
feat: add message column to kubectl get wf and argo list. Fixes #…
ee37656 
…8307 (#8353)

Signed-off-by: Rohan Kumar <[email protected]>
@sarabala1979 sarabala1979 mentioned this issue Apr 14, 2022
Closed
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sourikghosh sourikghosh

Labels
area/cli The `argo` CLI good first issue Good for newcomers type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add message column to kubectl get wf and argo list. Fixes #8307 rohankmr414/argo-workflows
2 participants
@alexec @sourikghosh