Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse JSON structured logs in Argo UI #6856

Closed
astanway opened this issue Oct 4, 2021 · 1 comment · Fixed by #10145
Closed

Parse JSON structured logs in Argo UI #6856

astanway opened this issue Oct 4, 2021 · 1 comment · Fixed by #10145
Labels
area/ui solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/feature Feature request

Comments

@astanway
Copy link

astanway commented Oct 4, 2021

Summary

When using FluentBit / FluentD, logs are written to stdout/stderr in a structured JSON format. It is difficult to read these easily in the Argo UI

Use Cases

When clicking through to the node main logs, it would be nice to see only the message component of a JSON structured log/

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@astanway astanway added the type/feature Feature request label Oct 4, 2021
krrrr38 added a commit to krrrr38/argo-workflows that referenced this issue Dec 12, 2021
@krrrr38
feat: parse workflow json log message automatically. Close argoproj#6856
b103d40 


Signed-off-by: krrrr38 <[email protected]>
@krrrr38 krrrr38 mentioned this issue Dec 12, 2021
Closed
1 task
krrrr38 added a commit to krrrr38/argo-workflows that referenced this issue Dec 12, 2021
@krrrr38
feat: parse workflow json log message automatically. Close argoproj#6856
6af2684 


Signed-off-by: krrrr38 <[email protected]>
krrrr38 added a commit to krrrr38/argo-workflows that referenced this issue Jan 7, 2022
@krrrr38
feat: parse workflow json log message automatically. Close argoproj#6856
31394e4 


Signed-off-by: krrrr38 <[email protected]>
krrrr38 added a commit to krrrr38/argo-workflows that referenced this issue Jan 10, 2022
@krrrr38
feat: add workflow json log field selector. Close argoproj#6856
c9af103 
Signed-off-by: krrrr38 <[email protected]>
@alexec alexec added the area/ui label Feb 7, 2022
@caelan-io caelan-io added the solution/suggested A solution to the bug has been suggested. Someone needs to implement it. label Nov 1, 2022
@isubasinghe isubasinghe mentioned this issue Dec 1, 2022
Merged
8 tasks
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this issue Feb 2, 2023
@krrrr38 @isubasinghe
feat: add workflow json log field selector. Close argoproj#6856
3ff2e7f 
Signed-off-by: krrrr38 <[email protected]>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this issue Feb 16, 2023
@krrrr38 @isubasinghe
feat: add workflow json log field selector. Close argoproj#6856
4c0cbb2 
Signed-off-by: krrrr38 <[email protected]>
@pmbrull
Copy link

pmbrull commented Mar 15, 2023

Thanks for popping this issue. We are seeing the same error when working with the logs on the Java SDK. We are getting an object that it's not parseable as a JSON (it's formatted as a JSONL).

The call fails internally in the SDK with com.google.gson.JsonSyntaxException. The only workaround is to patch internal calls to cast the result to a String that we then need to cook.

This is reproducible in the following example: https://github.com/pmbrull/argo-java-examples/blob/main/playground/src/main/java/SimpleWorkflowLogs.java

Thanks

sarabala1979 pushed a commit that referenced this issue Mar 21, 2023
@isubasinghe @krrrr38 @alexec
feat: Parse JSON structured logs in Argo UI. Fixes #6856 (#10145)
7da30bd 
Signed-off-by: krrrr38 <[email protected]>
Signed-off-by: Isitha Subasinghe <[email protected]>
Co-authored-by: krrrr38 <[email protected]>
Co-authored-by: Alex Collins <[email protected]>
@pmbrull pmbrull mentioned this issue Mar 22, 2023
Open
terrytangyuan added a commit that referenced this issue Apr 6, 2023
@terrytangyuan
Revert "feat: Parse JSON structured logs in Argo UI. Fixes #6856 (#10145
2abca7f 
)"

This reverts commit 7da30bd.
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this issue Jul 4, 2023
@isubasinghe @krrrr38
@alexec @JPZ13
feat: Parse JSON structured logs in Argo UI. Fixes argoproj#6856 (arg…
396674d 
…oproj#10145)

Signed-off-by: krrrr38 <[email protected]>
Signed-off-by: Isitha Subasinghe <[email protected]>
Co-authored-by: krrrr38 <[email protected]>
Co-authored-by: Alex Collins <[email protected]>
@terrytangyuan terrytangyuan mentioned this issue Aug 2, 2023
Closed
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this issue May 9, 2024
@terrytangyuan @dpadhiar
Revert "feat: Parse JSON structured logs in Argo UI. Fixes argoproj#6856
e56ab00 
 (argoproj#10145)"

This reverts commit 7da30bd.

Signed-off-by: Dillen Padhiar <[email protected]>
@agilgur5 agilgur5 mentioned this issue Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Parse JSON structured logs in Argo UI. Fixes #6856 isubasinghe/argo-workflows
4 participants
@astanway @alexec @pmbrull @caelan-io