UI (when 2 tabs open) 3.6.0rc4 - submit workflowtemplate greyed out

[tooptoop4]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug
• I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

in the ui it lets me create a new workflowtemplate and update it, but the button to submit it is greyed out. i'm using the quickstart

Version(s)

3.6.0rc4

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

default

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

n/a

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

n/a

[tooptoop4]

for this to happen looks like you need 2 workflow tabs open (in any of chrome or safari), workaround is to hard refresh via hold down command+shift keys and click the refresh icon in address bar

@MasonM maybe caused by 68adbcc#diff-0494089cd084aa91c5d8e043b283fe327f53ecf94623bf82be945dea2e2587fd ?

[Joibel]

I can reproduce this on firefox 131 on linux. I don't need a hard refresh, just a normal refresh to make the button appear, and the button appears greyed out without 2 tabs.

[MasonM]

@tooptoop4 The "submit" button was completely broken before that change for the reasons described at #13593, so it definitely didn't cause this. If this was a regression, it dates back at least to #13069

[MasonM]

Looking at this more, I think this is a consequence of reference equality checking. In my original fix for #13593, I had it use deep equality comparisons, which doesn't have this problem. However, I reverted that in 24c0206 because Anton had concerns about performance (see #13593 (comment)). I did figure out a way to fix this without affecting performance (see #13593 (comment)), but the problem is that's a significant change, and I don't know if there's anyone left that can code review such a change. So I think we're just going to have to live with this until there's someone available to code review UI changes.

[isubasinghe]

@MasonM I did initially start on argo with some UI contributions, I am a bit rusty, but I can review your code.

[MasonM]

@isubasinghe Thanks! I cleaned up the POC and entered #13915 for this

[MasonM]

Re-opening because #13913 didn't fully fix the issue, e.g. the "Submit" button is still grayed out after clicking "Update" button. #13915 will completely fix it.

[hmoulart]

Description:
After upgrading Argo Workflows to version 3.6.0, I encountered a regression where the "Submit" button is grayed out and cannot be clicked when attempting to submit a WorkflowTemplate.

Steps to Reproduce:

1. Go to the Argo Workflows UI.
2. Navigate to a WorkflowTemplate.
3. Attempt to click the "Submit" button (it is disabled).

Workaround:
I found a simple workaround:

1. Refresh the page by pressing Enter in the browser's URL bar.
2. After the refresh, the "Submit" button becomes clickable.

Environment:
Argo Workflows version: 3.6.0
Browser: Version 131.0.6778.71 (Build officiel) (x86_64)

Attachments:
Below are screenshots showing the issue:
Before refresh: "Submit" button is grayed out.

After refresh: "Submit" button is active.