Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for memoization without outputs did not catch regression #12129

Closed
3 tasks done
Joibel opened this issue Nov 3, 2023 · 0 comments · Fixed by #12215
Closed
3 tasks done

Tests for memoization without outputs did not catch regression #12129

Joibel opened this issue Nov 3, 2023 · 0 comments · Fixed by #12215
Assignees
@Joibel
Labels
area/memoization type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@Joibel
Copy link
Member

Joibel commented Nov 3, 2023 •
edited
Loading

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

The tests for #11379 did not catch when they were reverted in #11451. This is a placeholder to fix that.

#12130 fixes the regression.

Version

v3.5.0

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

N/A

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A
@Joibel Joibel added type/bug type/regression Regression from previous behavior (a specific type of bug) labels Nov 3, 2023
@Joibel Joibel self-assigned this Nov 3, 2023
Joibel added a commit to Joibel/argo-workflows that referenced this issue Nov 3, 2023
@Joibel
fix: regression in memoization without outputs
5cd1132 
The merge with argoproj#11451 reverted this, so this commit is just to
reinstate that.
The tests included in argoproj#11379 failed to catch this, I've raised argoproj#12129
for this, but in the interests of matching the documentation and
kubecon next week I'm putting this PR in now.

Fixes argoproj#12117

Signed-off-by: Alan Clucas <[email protected]>
@Joibel Joibel mentioned this issue Nov 3, 2023
Merged
Joibel added a commit to Joibel/argo-workflows that referenced this issue Nov 17, 2023
@Joibel
chore: add functional tests for memoization without outputs
0cf50f8 
Fixes argoproj#12129 - see that issue for details.

Add a couple of tests which check memoization still happens without
outputs.

These tests fail with c751e66
reverted.

Signed-off-by: Alan Clucas <[email protected]>
Joibel added a commit to Joibel/argo-workflows that referenced this issue Nov 17, 2023
@Joibel
chore: add functional tests for memoization without outputs
e1df3b9 
Fixes argoproj#12129 - see that issue for details.

Add a couple of tests which check memoization still happens without outputs.

Signed-off-by: Alan Clucas <[email protected]>
@Joibel Joibel mentioned this issue Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joibel Joibel

Labels
area/memoization type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add functional tests for memoization without outputs Joibel/argo-workflows
1 participant
@Joibel