Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add locators for Prompt OK and Cancel Buttons (#4393) #86

Merged
merged 1 commit into from
Dec 18, 2020
Merged

test: Add locators for Prompt OK and Cancel Buttons (#4393) #86

merged 1 commit into from
Dec 18, 2020

Conversation

keithchong
Copy link
Contributor

For argoproj/argo-cd#4393

The Delete Confirmation dialog was changed to a prompt dialog and the OK and Cancel buttons didn't already have locators.

Signed-off-by: Keith Chong [email protected]

@keithchong
Copy link
Contributor Author

keithchong commented Dec 16, 2020 •
edited
Loading

Hi @alexmt, please review

@keithchong keithchong mentioned this pull request Dec 18, 2020
Merged
7 tasks
alexmt
alexmt approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 37b6371 into argoproj:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithchong @alexmt