-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js version on CI #432
Conversation
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
7b87b52
to
48aec30
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Hey sorry, I totally didn't see this PR; thought you would make the change in that PR. This works too, just that #265 will need rebasing after this
This is good to have, just will have to make sure nothing else breaks from the more significant upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI build passes. Thanks for updating this!
It looks like the @terrytangyuan are you able to merge |
triggered |
Thanks Terry! The build ran this time, but failed due to the infamous |
So we could use the OpenSSL legacy provider to workaround the issue, as we did in argoproj/argo-workflows#11410 and argoproj/argo-workflows#11461, but I'd prefer to just update the deps so we don't have the OpenSSL vuln anyway (although it only impacts local dev, so not a huge deal). Unfortunately, the main dep that needs upgrading for that is Webpack, which is only used by Storybook in this repo. The problem there is that we're on an old version of Storybook, v6, which hasn't been updated since 2022. Upgrading to Storybook v7 is fairly non-trivial, not the least of which because there are actually three Storybook builds in this repo: for v1, v2, and I tried updating the deps and everything to at least get v2 working, but kept getting build error after build error fixing one-by-one. So this may very well not be worth upgrading given the current state of the repo per #453. Sooo I might just enable the OpenSSL legacy provider workaround instead and at least get Node updated to non-EoL (Storybook et al will have to come later I guess 😕 (if ever)) |
This comment was marked as resolved.
This comment was marked as resolved.
Pull request was closed
context: #265 (comment)
.nvmrc
from GitHub Actions workflows14.15
to18.17
because18.x
is current LTS version