bugfix:argo create command not support namespace in yaml file #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 81.60% 81.59% -0.02%
==========================================
Files 99 99
Lines 8732 8738 +6
==========================================
+ Hits 7126 7130 +4
- Misses 1151 1152 +1
- Partials 455 456 +1
Continue to review full report at Codecov.
|
zcc35357949
reviewed
Jan 26, 2021
| func (c *CreateOptions) getNamespace(un unstructured.Unstructured) string { | ||
| ns := c.ArgoRolloutsOptions.Namespace() | ||
| if md, ok := un.Object["metadata"]; ok { | ||
| metadata := md.(map[string]interface{}) |
There was a problem hiding this comment.
may panic here if metadata is not a map in the resource file.
There was a problem hiding this comment.
not write matadata name is invalid resource file,
it's error
modify before: [root@k8s-master-1 argo-rollouts]# grep namespace examples/rollout-canary.yaml namespace: base [root@k8s-master-1 argo-rollouts]# kubectl argo create -f examples/rollout-canary.yaml Error: the namespace of the provided object does not match the namespace sent on the request modify after: [root@k8s-master-1 argo-rollouts]# grep namespace examples/rollout-canary.yaml namespace: base [root@k8s-master-1 argo-rollouts]# kubectl argo create -f examples/rollout-canary.yaml rollout.argoproj.io/rollout-canary created [root@k8s-master-1 argo-rollouts]# Signed-off-by: zhaozhiqiang <[email protected]>
zhaoyun006
force-pushed
the
bugfix-argo-rollouts
branch
from
adc9655 to
9da9ab7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jessesuen
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify before:
[root@k8s-master-1 argo-rollouts]# grep namespace examples/rollout-canary.yaml
namespace: base
[root@k8s-master-1 argo-rollouts]# kubectl argo create -f examples/rollout-canary.yaml
Error: the namespace of the provided object does not match the namespace sent on the request
modify after:
[root@k8s-master-1 argo-rollouts]# grep namespace examples/rollout-canary.yaml
namespace: base
[root@k8s-master-1 argo-rollouts]# kubectl argo create -f examples/rollout-canary.yaml
rollout.argoproj.io/rollout-canary created
[root@k8s-master-1 argo-rollouts]#
Signed-off-by: zhaozhiqiang [email protected]
Checklist:
"fix(controller): Updates such and such. Fixes #1234".