Fix controller crash caused by glog attempting to write to /tmp #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 15 15
Lines 1721 1721
=======================================
Hits 1360 1360
Misses 267 267
Partials 94 94
Continue to review full report at Codecov.
|
alexmt
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #85
We were using a
k8s.io/apimachineryversion which somehow was using glog where it did not honor thelogtostderrflag in glog. This caused the controller to log to/tmpin certain cases, which crashed the controller since /tmp does not exist in scratch containers.This change also allows a dev version of the controller image, for much faster docker builds: