Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: kubectl argo create:161, command panic: runtime error: invali… #932

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

zhaoyun006
Copy link
Contributor

@zhaoyun006 zhaoyun006 commented Jan 6, 2021

…d memory address or nil pointer dereference

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2021

CLA assistant check
All committers have signed the CLA.

@zhaoyun006
Copy link
Contributor Author

Is anyone here

@jessesuen
Copy link
Member

Hi @zhaoyun006 the change looks good to me, could you sign your commit e.g. git commit --amend -s so that it can pass the DCO check?

@zhaoyun006
Copy link
Contributor Author

Hi @zhaoyun006 the change looks good to me, could you sign your commit e.g. git commit --amend -s so that it can pass the DCO check?

ok

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #932 (30d7b62) into master (1c93ebc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   81.77%   81.77%           
=======================================
  Files          99       99           
  Lines        8698     8699    +1     
=======================================
+ Hits         7113     7114    +1     
  Misses       1138     1138           
  Partials      447      447           
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/create/create.go 66.01% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c93ebc...366402e. Read the comment docs.

@zhaoyun006 zhaoyun006 force-pushed the bugfix-argo-rollouts branch from 9d18c44 to 30d7b62 Compare January 7, 2021 23:46
bugfix: kubectl argo create:161, command panic: runtime error: invalid memory address or nil pointer dereference

Signed-off-by: zhaozhiqiang <[email protected]>
@zhaoyun006 zhaoyun006 force-pushed the bugfix-argo-rollouts branch 2 times, most recently from 366402e to 4e1310c Compare January 7, 2021 23:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhaoyun006
Copy link
Contributor Author

Hi @zhaoyun006 the change looks good to me, could you sign your commit e.g. git commit --amend -s so that it can pass the DCO check?

It's done!

1 similar comment
@zhaoyun006
Copy link
Contributor Author

Hi @zhaoyun006 the change looks good to me, could you sign your commit e.g. git commit --amend -s so that it can pass the DCO check?

It's done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants