feat: metric fields can be parameterized by analysis arguments

[khhirani]

Closes #825

Signed-off-by: khhirani [email protected]

[codecov-io]

Codecov Report

Attention: Patch coverage is 78.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (2d90163) to head (8953e8c).
Report is 1207 commits behind head on master.

Files with missing lines	Patch %	Lines
utils/analysis/factory.go	73.68%	5 Missing and 5 partials ⚠️
.../apis/rollouts/validation/validation_references.go	55.55%	2 Missing and 2 partials ⚠️
analysis/analysis.go	92.59%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   81.74%   81.60%   -0.15%     
==========================================
  Files          99       99              
  Lines        8684     8732      +48     
==========================================
+ Hits         7099     7126      +27     
- Misses       1138     1151      +13     
- Partials      447      455       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jessesuen]

I see you made changes to all of the types, but I don't see any tests which actually test the feature. Where is a test which actually does substitution for a metric like:

  metrics:
  - name: error-rate
    provider:
      prometheus:
        interval: "{{args.interval}}"
        count: "{{args.count}}"

[jessesuen]

Also, an e2e would be nice, even if it is just modifying an existing one.

[jessesuen]

@khhirani you'll need to rebase on master to fix the codegen problem. I found a toolchain discrepancy between macOS kubectl vs. github's ubuntu-latest kubectl that causes the difference in manifests. I switched to using kustomize build instead of kubectl kustomize which fixed the problem, assuming you are running a moderately recent version of kustomize. Github runs v3.8

[khhirani]

@jessesuen Fixed

[jessesuen]

I see that everywhere where count used to be nil, is now doing count := intstr.FromInt(0) and I'd like to understand why, since nil and zero mean different things.

[jessesuen]

I don't think you changed this to intOrString

[jessesuen]

LGTM, please revert unintentional change to bluegreen.md before merging

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
4.2% Duplication