Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller needs patch privileges on events #89

Merged
merged 1 commit into from
May 23, 2019
Merged

Controller needs patch privileges on events #89

merged 1 commit into from
May 23, 2019

Conversation

jessesuen
Copy link
Member

Resolves #86

@jessesuen jessesuen requested a review from dthomson25 May 23, 2019 09:24
@codecov-io
Copy link

codecov-io commented May 23, 2019 •
edited
Loading

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files          15       15           
  Lines        1721     1721           
=======================================
  Hits         1360     1360           
  Misses        267      267           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a3afe...b3893ec. Read the comment docs.

dthomson25
dthomson25 approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jessesuen jessesuen merged commit 6719355 into argoproj:master May 23, 2019
@jessesuen jessesuen deleted the 86-missing-patch-event branch May 23, 2019 18:54
jessesuen added a commit that referenced this pull request May 24, 2019
@jessesuen
Controller needs patch privileges on events (#89)
de8cc09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthomson25 dthomson25 dthomson25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller is missing patch event privileges
3 participants
@jessesuen @codecov-io @dthomson25