Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename autoPromoteActiveServiceDelaySeconds to autoPromotionSeconds #77

Merged
merged 1 commit into from
May 17, 2019

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented May 16, 2019

Resolves #66

  • Rename autoPromoteActiveServiceDelaySeconds to autoPromotionSeconds
  • Improve and fix documentation for various fields

Improve and fix documentation for various fields
@jessesuen jessesuen requested review from alexmt and dthomson25 May 16, 2019 23:12
@jessesuen
Copy link
Member Author

jessesuen commented May 16, 2019

Other candidate names for this field:

  • autoPromotionSeconds
  • autoPromotionDelaySeconds
  • promotionDelaySeconds

@codecov-io
Copy link

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #77   +/-   ##
======================================
  Coverage    78.7%   78.7%           
======================================
  Files          15      15           
  Lines        1700    1700           
======================================
  Hits         1338    1338           
  Misses        269     269           
  Partials       93      93
Impacted Files Coverage Δ
controller/bluegreen.go 80.48% <100%> (ø) ⬆️
controller/pause.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2728e2c...dfaf3ba. Read the comment docs.

@jessesuen jessesuen changed the title Rename AutoPromoteActiveServiceDelaySeconds to autoPromotionSeconds Rename autoPromoteActiveServiceDelaySeconds to autoPromotionSeconds May 16, 2019
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit f541d8d into argoproj:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec documentation issues
3 participants