Scale down older RS on non-happy path #76
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 78.7% 78.48% -0.22%
==========================================
Files 15 15
Lines 1700 1678 -22
==========================================
- Hits 1338 1317 -21
Misses 269 269
+ Partials 93 92 -1
Continue to review full report at Codecov.
|
| recorder: &record.FakeRecorder{}, | ||
| } | ||
| scaled, err := controller.reconcileOldReplicaSets(allRSs, oldRSs, newRS, rollout) | ||
|
|
There was a problem hiding this comment.
Prior to changes, test was returning an empty replicaset instead of a modified rollout when the Update Rollout command was called. This caused a panic when the replicas pointer was dereferenced with the new changes. We needed to start the informers in order to have the reactor react on the update call and return the correct updated object.
| readyPodsFromOldRS: 10, | ||
| readyPodsFromNewRS: 9, | ||
| scaleExpected: false, | ||
| }, |
There was a problem hiding this comment.
No longer needed since we should scale down regardless of the new rs state
Solves the second half of #70 by scaling down and deleting old replicasets at any point of the rollout instead of just at the end.