Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where pod template hash could be computed inconsistently #75

Merged
merged 1 commit into from
May 16, 2019
Merged

Fix issue where pod template hash could be computed inconsistently #75

merged 1 commit into from
May 16, 2019

Conversation

jessesuen
Copy link
Member

No description provided.

@jessesuen jessesuen requested review from alexmt and dthomson25 May 16, 2019 02:26
@codecov-io
Copy link

codecov-io commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #75 into master will increase coverage by 0.05%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #75      +/-   ##
=========================================
+ Coverage   78.65%   78.7%   +0.05%     
=========================================
  Files          15      15              
  Lines        1691    1700       +9     
=========================================
+ Hits         1330    1338       +8     
  Misses        269     269              
- Partials       92      93       +1
Impacted Files Coverage Δ
controller/controller.go 51.04% <60%> (+0.22%) ⬆️
controller/bluegreen.go 80.48% <0%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f122387...077bbaf. Read the comment docs.

dthomson25
dthomson25 approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit b122a64 into argoproj:master May 16, 2019
@jessesuen jessesuen deleted the 70-pod-template-hash branch May 16, 2019 04:10
@jessesuen jessesuen mentioned this pull request May 16, 2019
Closed
dthomson25 pushed a commit that referenced this pull request May 18, 2019
@jessesuen @dthomson25
Fix issue where pod template hash could be computed inconsistently (#75)
7378566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthomson25 dthomson25 dthomson25 approved these changes

@alexmt alexmt Awaiting requested review from alexmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessesuen @codecov-io @dthomson25