Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previewReplicaCount to BG #64

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Add previewReplicaCount to BG #64

merged 1 commit into from
Apr 30, 2019

Conversation

dthomson25
Copy link
Member

No description provided.

@dthomson25 dthomson25 force-pushed the customizable-preview branch from d401101 to 9ff8215 Compare April 29, 2019 03:05
@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4b59abf). Click here to learn what that means.
The diff coverage is 82.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #64   +/-   ##
=========================================
  Coverage          ?   78.01%           
=========================================
  Files             ?       15           
  Lines             ?     1669           
  Branches          ?        0           
=========================================
  Hits              ?     1302           
  Misses            ?      276           
  Partials          ?       91
Impacted Files Coverage Δ
utils/replicaset/replicaset.go 94.26% <100%> (ø)
utils/replicaset/bluegreen.go 100% <100%> (ø)
controller/sync.go 74.24% <100%> (ø)
controller/bluegreen.go 78.12% <46.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b59abf...9ff8215. Read the comment docs.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@dthomson25 dthomson25 merged commit 8a6b715 into master Apr 30, 2019
@dthomson25 dthomson25 deleted the customizable-preview branch April 30, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants