Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to auto-promote active service #59

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Add ability to auto-promote active service #59

merged 1 commit into from
Apr 30, 2019

Conversation

dthomson25
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ce5920c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   78.38%           
=========================================
  Files             ?       14           
  Lines             ?     1633           
  Branches          ?        0           
=========================================
  Hits              ?     1280           
  Misses            ?      266           
  Partials          ?       87
Impacted Files Coverage Δ
controller/bluegreen.go 81.81% <100%> (ø)
controller/pause.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5920c...697d3c1. Read the comment docs.

@dthomson25 dthomson25 mentioned this pull request Apr 25, 2019
Closed
@dthomson25 dthomson25 changed the title Add ability to auto-promote active selector Add ability to auto-promote active service Apr 25, 2019
@dthomson25 dthomson25 requested a review from alexmt April 26, 2019 15:41
alexmt
alexmt approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit 3438a08 into master Apr 30, 2019
@dthomson25 dthomson25 deleted the pause branch April 30, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dthomson25 @codecov-io @alexmt