Add Scale Down Delay to BG #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=========================================
+ Coverage 77.11% 78.22% +1.1%
=========================================
Files 14 14
Lines 1595 1621 +26
=========================================
+ Hits 1230 1268 +38
+ Misses 278 266 -12
Partials 87 87
Continue to review full report at Codecov.
|
dthomson25
force-pushed
the
scaleDownDelay
branch
from
73dfaad to
54604dd
Compare
alexmt
approved these changes
Apr 25, 2019
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| // +optional | ||
| ScaleDownDelay *int32 `json:"scaleDownDelay,omitempty"` |
There was a problem hiding this comment.
I would rename it to ScaleDownDelaySeconds for clarity ( other k8s resource field follows that conversion too e.g. Deployment ProgressDeadlineSeconds, MinReadySeconds )
dthomson25
force-pushed
the
scaleDownDelay
branch
from
54604dd to
5e683ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.