feat: Allow AnalysisTemplates to reference secrets #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cretInformer to retrieve secrets more efficiently
…to webmetric-ref-secrets
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=========================================
+ Coverage 84.5% 84.6% +0.09%
=========================================
Files 70 71 +1
Lines 6667 6721 +54
=========================================
+ Hits 5634 5686 +52
- Misses 746 747 +1
- Partials 287 288 +1
Continue to review full report at Codecov.
|
dthomson25
suggested changes
Feb 28, 2020
There was a problem hiding this comment.
Hi @khhirani, I have some questions and minor style comments, but overall I think this PR is a really good start!
A couple things I noticed at a high level:
- You are going to need to rebase with master since you have a merge conflict
- We shouldn't close Ability for web metric to reference secret content #372 until we add the functionality to ignore secrets that do not have a specific annotation
khhirani
changed the title
…rgo-rollouts into webmetric-ref-secrets
golangcibot
reviewed
Mar 2, 2020
…rrole to allow get/watch/list secrets
…f is valid in resolveArgs
golangcibot
reviewed
Mar 3, 2020
golangcibot
reviewed
Mar 3, 2020
dthomson25
reviewed
Mar 3, 2020
golangcibot
reviewed
Mar 4, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified AnalysisTemplates to allow Metric Providers to reference secrets (Resolves #372)
Created a RedactorFormatter to redact secrets from log messages