chore: Rerun codegen and gen manifests #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 83.97% 83.97%
=======================================
Files 70 70
Lines 6528 6528
=======================================
Hits 5482 5482
Misses 750 750
Partials 296 296Continue to review full report at Codecov.
|
dthomson25
changed the title
jessesuen
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the #318 merge, a merge conflict with the manifests get in and that commit used a different version of the codegen. This PR fixes the merge conflict and uses the older version of the codegen (the same version the maintainers are using). I will open up another issue to standardize the version of the code generator.