fix(dashboard): Update pod status logic to support native sidecars. Fixes #3366

[martynd]

Closes #3366
Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (3024c2a) to head (3bd5f26).
Report is 67 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/kubectl-argo-rollouts/info/pod_info.go	12.50%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
+ Coverage   84.23%   84.34%   +0.10%     
==========================================
  Files         154      154              
  Lines       18014    18021       +7     
==========================================
+ Hits        15174    15199      +25     
+ Misses       1996     1989       -7     
+ Partials      844      833      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Go Published Test Results

2 171 tests   2 171 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit b4c79af.

♻️ This comment has been updated with latest results.

[github-actions]

E2E Tests Published Test Results

  4 files    4 suites   3h 24m 0s ⏱️
111 tests 101 ✅  6 💤 4 ❌
452 runs  420 ✅ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit b4c79af.

♻️ This comment has been updated with latest results.

[Hronom]

Any news to make it not draft?

[martynd]

Any news to make it not draft?

I need a change to add tests as its failing the coverage checks. Theres no existing tests for any of this however to just extend which complicates it a little

[Hronom]

Nice, can't wait for support for native sidecars. Right now Argo Rollouts some sort of blocker for it

[rsavage-nozominetworks]

Hi folks, any way to make this a priority? Seeing the same issue here.

[martynd]

Ive still not got around to doing the tests but I've marked it as ready anyway in case the maintainers are willing to waive the requirement given the absence of testing for for all the functionality there in any form

[rsavage-nozominetworks]

Ive still not got around to doing the tests but I've marked it as ready anyway in case the maintainers are willing to waive the requirement given the absence of testing for for all the functionality there in any form

How can we get the maintainers involved? Seems like they are ignoring this issue. I posted a message in the argo-rollouts slack channel yesterday, and zero response.

[tbronchain]

Facing the issue also.

I manage to still use Argo (rollouts/cd) but the rollout status is not properly reported to ArgoCD, which seems to trigger a "bug" with some replicaset showing as ProgressDeadlineExceeded (#3457).

The Issue seem to be "cosmetics" only (rollouts are properly promoted) but I'm wondering if some extra logic is being used during deployments, it may break.

Big thanks to whoever will look into this :)

[zachaller]

Can you fix the lint issue by running make lint

[Hronom]

Hello, do you have sense when it will be released approximately?

Asking because it becomes a major blocker to enable sidecars nowadays if you have in your stack Argo Rollouts.

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 30m 58s ⏱️
111 tests  95 ✅  6 💤 10 ❌
460 runs  421 ✅ 24 💤 15 ❌

For more details on these failures, see this check.

Results for commit 3bd5f26.

♻️ This comment has been updated with latest results.

[github-actions]

Published Unit Test Results

2 174 tests   2 174 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 3bd5f26.

♻️ This comment has been updated with latest results.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Hronom]

Hello, @zachaller do you have sense when it will be released?