-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs site version selector broken #3590
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3590 +/- ##
=======================================
Coverage 80.27% 80.27%
=======================================
Files 156 156
Lines 17964 17964
=======================================
Hits 14420 14420
Misses 2631 2631
Partials 913 913 ☔ View full report in Codecov by Sentry. |
Go Published Test Results2 163 tests 2 163 ✅ 2m 54s ⏱️ Results for commit c125d24. ♻️ This comment has been updated with latest results. |
E2E Tests Published Test Results 4 files 4 suites 3h 26m 8s ⏱️ For more details on these failures, see this check. Results for commit c125d24. ♻️ This comment has been updated with latest results. |
fb0b947
to
8740c7f
Compare
@zachaller I updated read-the-docs and from now on it will create Pull Request previews for the docs. This way we can check the rendering of docs for PRs like this that affect docs. It will take effect in the next commit/PR that somebody opens. |
8740c7f
to
d1ae763
Compare
@kostis-codefresh thanks it worked really well: https://argo-rollouts--3590.org.readthedocs.build/en/3590/ |
Signed-off-by: xiaowu.zhu <[email protected]> Signed-off-by: root <[email protected]>
d1ae763
to
c125d24
Compare
@yyzxw many thanks for addressing this 🙂 |
Signed-off-by: xiaowu.zhu <[email protected]> Signed-off-by: root <[email protected]>
Signed-off-by: xiaowu.zhu <[email protected]> Signed-off-by: root <[email protected]>
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.the docs site version selector dropdown is broken
Fixed the version selector. Also added version information warning as with ArgoCD