Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Amadeus to Users.md #3527

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Apr 15, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Guillaume Doussin <[email protected]>
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Go Published Test Results

2 160 tests   2 160 ✅  2m 53s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 0ffb4dd.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (8405f2e) to head (0ffb4dd).
Report is 92 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3527      +/-   ##
==========================================
- Coverage   81.83%   78.21%   -3.63%     
==========================================
  Files         135      158      +23     
  Lines       20688    18397    -2291     
==========================================
- Hits        16931    14389    -2542     
- Misses       2883     3101     +218     
- Partials      874      907      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 25m 40s ⏱️
110 tests  97 ✅  6 💤  7 ❌
450 runs  416 ✅ 24 💤 10 ❌

For more details on these failures, see this check.

Results for commit 0ffb4dd.

@wherka-ama
Copy link

Hello,
please note the PR is blessed by the Amadeus OSPO who I'm representing here.

@OpenGuidou : thank you very much for your contribution to Argo Project and to Open Source in general. We really proud of you ❤️

I would also express my gratitude to the Argo Project community for a stellar work on such an important area! We truly commend you for that.
we'll try to be supportive of your efforts in a way of direct contributions(like these submitted by @OpenGuidou and other employees of our company) and by other means - the feedback and some internal sessions designed to spread the good word about the tooling provided by this community.

Feel free to reach out to me if you are interested in speaking to our engineering community - hundreds(conservative estimate) of fantastic engineers eager to learn about technology. I would be happy to facilitate it :)

Cheers,
Waldek(Amadeus OSPO)

Copy link

@wherka-ama wherka-ama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I'm acting as an Amadeus OSPO here and I'm more than happy to see our beloved company on this list :-)

/LGTM

@zachaller zachaller merged commit 1856c3c into argoproj:master Apr 18, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants