Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the max traffic weight support for the traffic routing (nginx/plugins). #3215

Merged

Conversation

andyliuliming
Copy link
Contributor

@andyliuliming andyliuliming commented Dec 5, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Go Published Test Results

2 137 tests   2 137 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit a9e40dc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

E2E Tests Published Test Results

  4 files    4 suites   3h 44m 18s ⏱️
107 tests  96 ✅  6 💤  5 ❌
452 runs  403 ✅ 24 💤 25 ❌

For more details on these failures, see this check.

Results for commit a9e40dc.

♻️ This comment has been updated with latest results.

@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch 2 times, most recently from 444f21c to 73d3ae5 Compare December 10, 2023 14:55
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.89%. Comparing base (8405f2e) to head (a9e40dc).
Report is 31 commits behind head on master.

Files Patch % Lines
rollout/trafficrouting/nginx/nginx.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3215      +/-   ##
==========================================
+ Coverage   81.83%   82.89%   +1.05%     
==========================================
  Files         135      135              
  Lines       20688    16916    -3772     
==========================================
- Hits        16931    14023    -2908     
+ Misses       2883     2015     -868     
- Partials      874      878       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch 5 times, most recently from c9ec175 to ffc8429 Compare December 11, 2023 04:13
@andyliuliming
Copy link
Contributor Author

andyliuliming commented Dec 12, 2023

trying to resolve
#2901
#2889
#2657

@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch from 9059e4d to ff29f25 Compare December 13, 2023 07:30
@andyliuliming andyliuliming changed the title [draft pr] add the max traffic weight support for the traffic routing. [draft pr] add the max traffic weight support for the traffic routing (nginx/plugins). Dec 13, 2023
@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch 2 times, most recently from 7582dc6 to d5dd5d4 Compare December 19, 2023 03:08
@andyliuliming andyliuliming marked this pull request as ready for review December 19, 2023 03:09
@andyliuliming andyliuliming changed the title [draft pr] add the max traffic weight support for the traffic routing (nginx/plugins). feature: add the max traffic weight support for the traffic routing (nginx/plugins). Dec 19, 2023
@andyliuliming andyliuliming changed the title feature: add the max traffic weight support for the traffic routing (nginx/plugins). feat: add the max traffic weight support for the traffic routing (nginx/plugins). Dec 19, 2023
@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch 5 times, most recently from c327863 to ad3ac7e Compare December 19, 2023 16:35
@andyliuliming
Copy link
Contributor Author

@zachaller could you please help take a look when you have time? thanks.

@andyliuliming
Copy link
Contributor Author

@zachaller any chance to help do a review? thanks.

@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch from f914b8b to 9acd096 Compare January 3, 2024 02:40
@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch from 67f25eb to a77ad35 Compare February 21, 2024 16:25
@andyliuliming andyliuliming force-pushed the andliu/maxtrafficweightsupport branch from a77ad35 to 8b09b45 Compare February 27, 2024 05:53
@andyliuliming
Copy link
Contributor Author

@zachaller ping :)
if this merged to master sooner, that will save us a little time to maintain a copy of the repo for this feature (both with this feature and the fixes we need from master branch).
could you please help review? thanks.

Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.1% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller enabled auto-merge (squash) March 6, 2024 00:40
@zachaller zachaller merged commit 017537b into argoproj:master Mar 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants