Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: istio destionationrule subsets enforcement #3189

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dnguy078
Copy link
Contributor

@dnguy078 dnguy078 commented Nov 28, 2023

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Go Published Test Results

2 095 tests   2 095 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 88e14f5.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fab0f2) 81.82% compared to head (5a6ccf4) 81.88%.

❗ Current head 5a6ccf4 differs from pull request most recent head 88e14f5. Consider uploading reports for the commit 88e14f5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
+ Coverage   81.82%   81.88%   +0.06%     
==========================================
  Files         135      134       -1     
  Lines       20633    20568      -65     
==========================================
- Hits        16882    16842      -40     
+ Misses       2880     2864      -16     
+ Partials      871      862       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnguy078 dnguy078 force-pushed the revert-3147-revert-3126 branch from 0f8d9aa to 5a6ccf4 Compare November 28, 2023 22:54
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

github-actions bot commented Nov 28, 2023

E2E Tests Published Test Results

  4 files    4 suites   3h 31m 3s ⏱️
106 tests  96 ✅  6 💤  4 ❌
434 runs  400 ✅ 24 💤 10 ❌

For more details on these failures, see this check.

Results for commit 88e14f5.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant