chore: bump gotestsum and fix flakey test causing nil channel send #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2934 +/- ##
=======================================
Coverage 81.74% 81.74%
=======================================
Files 134 134
Lines 20367 20367
=======================================
Hits 16649 16649
Misses 2861 2861
Partials 857 857 ☔ View full report in Codecov by Sentry. |
zachaller
force-pushed
the
bump-gotestsum
branch
from
99fd17e to
8dff67d
Compare
zachaller
changed the title
Signed-off-by: zachaller <[email protected]>
So deferes are called in a last-in-first-out order this means, that we would close the channel before canceling the context which could lead to a nil pointer usage. Let's just manually control order. Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
zachaller
force-pushed
the
bump-gotestsum
branch
from
24c9e81 to
d770d5b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gotestsum now fails on nil pointers by default which is why this test issue is being fixed here as well
Change order of defer to prevent using closed channel
So deferes are called in a last-in-first-out order this means,
that we would close the channel before canceling the context which could
lead to a nil pointer usage. Let's just manually control order. We will also deregister the callbacks.