Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to kubectl argo rollouts set image *=myrepo/myimage #290

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Nov 13, 2019

Adds the following capability:

$ kubectl argo rollouts set image rollout-baseline-vs-canary "*=argoproj/rollouts-demo:purple"
rollout "rollout-baseline-vs-canary" image updated

This matches the behavior of kubectl set image, e.g.:

kubectl set image daemonset abc *=nginx:1.9.1

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #290 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   83.77%   83.77%           
=======================================
  Files          63       63           
  Lines        5665     5665           
=======================================
  Hits         4746     4746           
  Misses        671      671           
  Partials      248      248
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/set/set_image.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94f66d...9f7cad5. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit 584df23 into argoproj:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants