Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset ProgressDeadline on retry #282

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Reset ProgressDeadline on retry #282

merged 1 commit into from
Nov 8, 2019

Conversation

dthomson25
Copy link
Member

No description provided.

@dthomson25
Copy link
Member Author

closes #279

jessesuen
jessesuen reviewed Nov 8, 2019
View reviewed changes
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Area of improvement later: would this problem more simply be solved by resetting the progress timestamp whenever we start changing steps, replicasets, etc...

@dthomson25 dthomson25 merged commit d32942a into master Nov 8, 2019
@dthomson25 dthomson25 deleted the reset-progress-after-abort branch November 8, 2019 19:00
@dthomson25 dthomson25 mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dthomson25 @jessesuen