Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make new alb fullName field optional for backward compatability #2806

Merged
merged 1 commit into from
May 24, 2023
Merged

fix: make new alb fullName field optional for backward compatability #2806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions manifests/crds/rollout-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3318,7 +3318,6 @@ spec:
type: string
required:
- arn
- fullName
- name
type: object
loadBalancer:
Expand All @@ -3331,7 +3330,6 @@ spec:
type: string
required:
- arn
- fullName
- name
type: object
stableTargetGroup:
Expand All @@ -3344,7 +3342,6 @@ spec:
type: string
required:
- arn
- fullName
- name
type: object
type: object
Expand Down
3 changes: 0 additions & 3 deletions manifests/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14552,7 +14552,6 @@ spec:
type: string
required:
- arn
- fullName
- name
type: object
loadBalancer:
Expand All @@ -14565,7 +14564,6 @@ spec:
type: string
required:
- arn
- fullName
- name
type: object
stableTargetGroup:
Expand All @@ -14578,7 +14576,6 @@ spec:
type: string
required:
- arn
- fullName
- name
type: object
type: object
Expand Down
3 changes: 2 additions & 1 deletion pkg/apiclient/rollout/rollout.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,8 @@
"type": "string"
},
"fullName": {
"type": "string"
"type": "string",
"title": "FullName is the full name of the resource\n+optional"
}
}
},
Expand Down
2 changes: 2 additions & 0 deletions pkg/apis/rollouts/v1alpha1/generated.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions pkg/apis/rollouts/v1alpha1/openapi_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions pkg/apis/rollouts/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,8 +1007,10 @@ type ALBStatus struct {
}

type AwsResourceRef struct {
Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
ARN string `json:"arn" protobuf:"bytes,2,opt,name=arn"`
Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
ARN string `json:"arn" protobuf:"bytes,2,opt,name=arn"`
// FullName is the full name of the resource
// +optional
FullName string `json:"fullName" protobuf:"bytes,3,opt,name=fullName"`
}

Expand Down